All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Fix OpenBSD linker warnings
Date: Mon, 18 Aug 2008 09:09:44 -0500	[thread overview]
Message-ID: <48A982A8.4030800@codemonkey.ws> (raw)
In-Reply-To: <f43fc5580808151320v6a0c40b2o2491f85d11196b35@mail.gmail.com>

Blue Swirl wrote:
> OpenBSD gcc issues warnings for some suspicious constructs, like:
> slirp/tcp_subr.c:1077: warning: Array size (256) smaller than format
> string size (257) (arg 3)
> vl.o(.text+0x7bc0): In function `drive_init':
> vl.c:5464: warning: strcpy() is almost always misused, please use strlcpy()
>
> This patch silences the warnings. Comments?
>   

Definitely a good thing.  strcpy()/sprintf() should never be used IMHO.

Regards,

Anthony Liguori

      parent reply	other threads:[~2008-08-18 14:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-15 20:20 [Qemu-devel] [PATCH] Fix OpenBSD linker warnings Blue Swirl
2008-08-17 20:19 ` [Qemu-devel] " Blue Swirl
2008-08-18 14:09 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A982A8.4030800@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.