From: Patrick McHardy <kaber@trash.net>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: davem@davemloft.net, netfilter-devel@vger.kernel.org
Subject: Re: netfilter 01/06: Move linux/in.h and linux/in6.h inclusions outside of
Date: Mon, 18 Aug 2008 19:01:12 +0200 [thread overview]
Message-ID: <48A9AAD8.9050104@trash.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0808181253010.3180@fbirervta.pbzchgretzou.qr>
Jan Engelhardt wrote:
> On Monday 2008-08-18 12:51, Patrick McHardy wrote:
>
>> netfilter: Move linux/in.h and linux/in6.h inclusions outside of #ifdef __KERNEL__
>>
>> netfilter.h can't be used in userspace without including linux/in.h
>> and linux/in6.h first. netfilter.h includes its own linux/in.h and
>> linux/in6.h include statements, these are stripped by make
>> headers-install because they are inside #ifdef __KERNEL__ however.
>> Move them out to fix this.
>
> Humm - no, I do not think this is right.
>
>
> $ cat test2.c
> #include <netinet/in.h>
>
> /* simulate netfilter.h as proposed */
> #include <linux/in.h>
Hmm good point. Dave, please drop this patch.
next prev parent reply other threads:[~2008-08-18 17:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 16:51 netfilter 00/06: netfilter fixes Patrick McHardy
2008-08-18 16:51 ` netfilter 01/06: Move linux/in.h and linux/in6.h inclusions outside of Patrick McHardy
2008-08-18 16:57 ` Jan Engelhardt
2008-08-18 17:01 ` Patrick McHardy [this message]
2008-08-19 4:21 ` David Miller
2008-08-18 16:51 ` netfilter 02/06: ipt_addrtype: fix matching of inverted destination address type Patrick McHardy
2008-08-19 4:30 ` David Miller
2008-08-18 16:51 ` netfilter 03/06: ctnetlink: fix double helper assignation for NAT'ed conntracks Patrick McHardy
2008-08-19 4:31 ` David Miller
2008-08-18 16:51 ` netfilter 04/06: ctnetlink: fix sleep in read-side lock section Patrick McHardy
2008-08-19 4:31 ` David Miller
2008-08-18 16:51 ` netfilter 05/06: ctnetlink: sleepable allocation with spin lock bh Patrick McHardy
2008-08-19 4:31 ` David Miller
2008-08-18 16:51 ` nf_nat 06/06: use secure_ipv4_port_ephemeral() for NAT port randomization Patrick McHardy
2008-08-19 4:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48A9AAD8.9050104@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=jengelh@medozas.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.