All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [Qemu-devel] Re: [RESEND #3][PATCH] i386: Catch all non-present ptes in cpu_get_phys_page_debug
Date: Mon, 18 Aug 2008 13:00:38 -0500	[thread overview]
Message-ID: <48A9B8C6.60003@codemonkey.ws> (raw)
In-Reply-To: <48A99A30.5040708@web.de>

Jan Kiszka wrote:
> It helps debugging guests when yet unmapped pages are correctly reported
> as, well, unmapped.
>   

Applied.  Thanks.

Regards,

Anthony Liguori

> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> ---
>  target-i386/helper.c |    6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> Index: b/target-i386/helper.c
> ===================================================================
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -1192,6 +1192,8 @@ target_phys_addr_t cpu_get_phys_page_deb
>              page_size = 4096;
>              pte = ldq_phys(pte_addr);
>          }
> +        if (!(pte & PG_PRESENT_MASK))
> +            return -1;
>      } else {
>          uint32_t pde;
>  
>
>
>   

      reply	other threads:[~2008-08-18 18:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-08 14:32 [Qemu-devel] [PATCH] i386: Catch all non-present ptes in cpu_get_phys_page_debug Jan Kiszka
2008-07-01  6:43 ` [Qemu-devel] [RESEND][PATCH] " Jan Kiszka
2008-07-13 12:43   ` [Qemu-devel] [RESEND #2][PATCH] " Jan Kiszka
2008-08-18  7:09     ` [Qemu-devel] [RESEND #3][PATCH] " Jan Kiszka
2008-08-18 13:58       ` Anthony Liguori
2008-08-18 15:50         ` [Qemu-devel] " Jan Kiszka
2008-08-18 18:00           ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48A9B8C6.60003@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@web.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.