From: Andi Kleen <ak@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
Pavel Machek <pavel@suse.cz>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Robert Richter <robert.richter@amd.com>,
Philippe Elie <phil.el@wanadoo.fr>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: oprofile + hibernation = badness
Date: Tue, 19 Aug 2008 14:12:38 +0200 [thread overview]
Message-ID: <48AAB8B6.3020802@linux.intel.com> (raw)
In-Reply-To: <20080819094905.GA20590@elte.hu>
Ingo Molnar wrote:
> * Vegard Nossum <vegard.nossum@gmail.com> wrote:
>
>> This gets rid of the suspend warnings, so it looks to be a step in the
>> right direction! FWIW, you may add my Tested-by to the patch.
>
> i've queued it up in tip/x86/oprofile - thanks guys.
I would have thought Robert would take them? He's oprofile
maintainer after all.
>
> Andi, another issue: your patch had 5 spurious whitespace errors. This
> is a reoccuring, many years pattern of behavior from you and you need to
> fix your workflow to send less sloppy patches.
Yes I forgot you define patch cleanness based on white space.
Seriously, It's actually new -- i did this one in git directly instead of
quilt and git-commit doesn't seem to know how to drop them. In my older quilt
workflow they were always automatically dropped since many years. Both emacs
and vim add them and I don't plan to switch editors, sorry.
> I fixed up the problems of this patch, no need to resend.
I hope you fixed the typos in the commit log too (it really was just
a RFC test patch)
-Andi
next prev parent reply other threads:[~2008-08-19 12:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 20:32 oprofile + hibernation = badness Vegard Nossum
2008-08-18 20:51 ` Rafael J. Wysocki
2008-08-18 21:08 ` Vegard Nossum
2008-08-18 21:15 ` Rafael J. Wysocki
2008-08-18 21:29 ` Andrew Morton
2008-08-19 1:13 ` Andi Kleen
2008-08-19 7:12 ` Vegard Nossum
2008-08-19 9:49 ` Ingo Molnar
2008-08-19 12:12 ` Andi Kleen [this message]
2008-08-19 12:37 ` Robert Richter
2008-08-19 12:56 ` Johannes Weiner
2008-08-19 13:18 ` Andi Kleen
2008-08-19 13:18 ` Ingo Molnar
2008-09-01 16:34 ` Robert Richter
2008-09-05 17:58 ` Ingo Molnar
2008-09-05 18:59 ` Robert Richter
2008-09-05 20:31 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AAB8B6.3020802@linux.intel.com \
--to=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=phil.el@wanadoo.fr \
--cc=rjw@sisk.pl \
--cc=robert.richter@amd.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.