From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755200AbYHTDbK (ORCPT ); Tue, 19 Aug 2008 23:31:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752923AbYHTDa5 (ORCPT ); Tue, 19 Aug 2008 23:30:57 -0400 Received: from E23SMTP03.au.ibm.com ([202.81.18.172]:57024 "EHLO e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752845AbYHTDa4 (ORCPT ); Tue, 19 Aug 2008 23:30:56 -0400 Message-ID: <48AB8FEA.8000006@linux.vnet.ibm.com> Date: Wed, 20 Aug 2008 09:00:50 +0530 From: Balbir Singh Reply-To: balbir@linux.vnet.ibm.com Organization: IBM User-Agent: Thunderbird 2.0.0.16 (X11/20080724) MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: LKML , "yamamoto@valinux.co.jp" , "nishimura@mxp.nes.nec.co.jp" , ryov@valinux.co.jp Subject: Re: [PATCH -mm][preview] memcg: a patch series for next [0/9] References: <20080819173014.17358c17.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080819173014.17358c17.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org KAMEZAWA Hiroyuki wrote: > Hi, > > This post is for showing what I'm trying now. > > This patch set is for memory resource controller. > 4 purposes here. > - improve performance of memcg. > - remove lock_page_cgroup() > - making page_cgroup->flags to be atomic_ops. > - support mem+swap controller. > > But this is still under test and the series is not well organised. > and base tree is old. (2.6.27-rc1-mm1) I'll rebase this set to newer mmtom tree. > > Maybe this set have some troubles/objections but I think the direction is not bad. > > Patch description. (patch ordering is bad. I'll fix in the next post.) > > [1/9] ... private_counter ...replace res_counter with my own counter. > This is for supporting mem+swap controller. > (And I think memcg has a bit different characteristics from other > users of res_counter....) > > [2/9] ... change-order-uncharge ... > This patch is for making it easy to handle swap-cache. > > [3/9] ... atomic_flags > This patch changes operations for page_cgroup->flags to be atomic_ops. > > [4/9] ... delayed freeing. > delaying to free page_cgroup at uncharge. > > [5/9] ... RCU freeing of page_cgroup > free page_cgroup by RCU. > > [6/9] ... lockress page cgroup. > remove lock_page_cgroup() and use RCU semantics. > > [7/9] ... add preftech > add prefetch() macro > > [8/9] ... mem+swap controller base. > introduce mem+swap controller. A bit big patch....but have tons of TODO. > and have troubles. (it seems it's difficult to cause OOM killer.) > > [9/9] ... mem+swap controller control files. > add mem+swap controller's control files. > > I'd like to push patch [2,3,4,5,6,7] first. > I took a quick look at the patches, patch 1 seemed not so clear, why can't we enhance or fix resource counters? I'll review/test the patches tonight. -- Balbir