From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <48ABE0C6.2010602@domain.hid>
Date: Wed, 20 Aug 2008 11:15:50 +0200
From: Jan Kiszka <jan.kiszka@domain.hid>
MIME-Version: 1.0
References: <48AB4256.6050200@domain.hid> <48ABDD08.8060707@domain.hid>
In-Reply-To: <48ABDD08.8060707@domain.hid>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Xenomai-core] [PATCH] Clean up XNWAKEN / wwake tracking
List-Id: "Xenomai life and development \(bug reports, patches,
	discussions\)" <xenomai.xenomai.org>
List-Unsubscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
List-Archive: </public/xenomai-core>
List-Post: <mailto:xenomai@xenomai.org>
List-Help: <mailto:xenomai-core-request@domain.hid>
List-Subscribe: <https://mail.gna.org/listinfo/xenomai-core>,
	<mailto:xenomai-core-request@domain.hid>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Cc: Jan Kiszka <jan.kiszka@domain.hid>, Xenomai-core@domain.hid

Gilles Chanteperdrix wrote:
> Jan Kiszka wrote:
>> +	/* We are awake, no one must steal our lock anymore. */
>> +	thread->wwake = NULL;
>> +
> 
> This is wrong, whether or not no one must steal our lock anymore will be
> decided at the "redo" label, when we "test and set", the synch owner.
> 

Maybe I should have added "(in case we actually got it)". If not, that
assignment is a nop. If we redo the whole thing, we would have cleared
XNWAKEN in xnpod_suspend_thread before suspension, so the effect should
be the same.

Jan

-- 
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux