From: Avi Kivity <avi@qumranet.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: kvm@vger.kernel.org, riel@surriel.com
Subject: Re: [PATCH][RESEND] x86 emulator: Add in/out instructions (opcodes 0xe4-0xe7, 0xec-0xef)
Date: Wed, 20 Aug 2008 16:02:58 +0300 [thread overview]
Message-ID: <48AC1602.2080809@qumranet.com> (raw)
In-Reply-To: <48AC150F.50407@qumranet.com>
Avi Kivity wrote:
>> To be clear, do you want an emulator test case (in
>> user/test/x86/emulator.c) for every instruction added to the emulator?
>>
>
> Yes. We've been bitten by rarely-used instructions being broken.
>
> I've now added a simple harness to test these instructions. It works
> by jumping into big real mode, forcing kvm to emulate (if
> emulate_invalid_guest_state=1) and returning.
>
> Please review it as well as the few fixes I've made in kvm to support
> it. It's in the 'realmode' branch of both kvm.git and
> kvm-userspace.git. Once it passes regression testing, I'll merge it
> into master.
>
The harness is in a new file, user/test/x86/realmode.c, btw. emulate.c
will be used for 64-bit instructions.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-08-20 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 19:07 [PATCH][RESEND] x86 emulator: Add in/out instructions (opcodes 0xe4-0xe7, 0xec-0xef) Mohammed Gamal
2008-08-20 8:42 ` Avi Kivity
2008-08-20 11:57 ` Mohammed Gamal
2008-08-20 12:58 ` Avi Kivity
2008-08-20 13:02 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AC1602.2080809@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.