From: Manfred Spraul <manfred@colorfullife.com>
To: hskinnemoen@atmel.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: AVR32: nmi_enter() without nmi_exit()
Date: Wed, 20 Aug 2008 15:39:59 +0200 [thread overview]
Message-ID: <48AC1EAF.9040906@colorfullife.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Hi Haavard,
You are listed as the maintainer for AVR32. If someone else is doing
that now, could you forward the mail?
While updating the rcu code, I noticed that do_nmi() for AVR32 is odd:
There is an nmi_enter() call without an nmi_exit().
This can't be correct, it breaks rcu (at least the preempt version) and
lockdep.
Attached is a patch, not tested at all.
--
Manfred
[-- Attachment #2: patch-avr32-nmi-exit --]
[-- Type: text/plain, Size: 614 bytes --]
diff --git a/arch/avr32/kernel/traps.c b/arch/avr32/kernel/traps.c
index b835c4c..c39cdfc 100644
--- a/arch/avr32/kernel/traps.c
+++ b/arch/avr32/kernel/traps.c
@@ -120,11 +120,11 @@ asmlinkage void do_nmi(unsigned long ecr, struct pt_regs *regs)
case NOTIFY_BAD:
die("Fatal Non-Maskable Interrupt", regs, SIGINT);
default:
+ printk(KERN_ALERT "Got NMI, but nobody cared. Disabling...\n");
+ nmi_disable();
break;
}
-
- printk(KERN_ALERT "Got NMI, but nobody cared. Disabling...\n");
- nmi_disable();
+ nmi_exit();
}
asmlinkage void do_critical_exception(unsigned long ecr, struct pt_regs *regs)
next reply other threads:[~2008-08-20 13:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 13:39 Manfred Spraul [this message]
2008-09-19 10:47 ` AVR32: nmi_enter() without nmi_exit() Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AC1EAF.9040906@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.