From: Patrick McHardy <kaber@trash.net>
To: adobriyan@gmail.com
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] nf_conntrack_sip: fix by making helper pointers thread-local
Date: Thu, 21 Aug 2008 13:28:56 +0200 [thread overview]
Message-ID: <48AD5178.4040101@trash.net> (raw)
In-Reply-To: <20080820200900.GA32237@x200.localdomain>
adobriyan@gmail.com wrote:
> Patrick, do I read correctly that ->help hook can run concurrently with itself?
>
> If yes, apply this patch to fix potential crashes and all sorts of
> nasties.
>
>
>
> [PATCH] nf_conntrack_sip: de-static helper pointers
>
> Helper's ->help hook can run concurrently with itself, so iterating over
> SIP helpers with static pointer won't work reliably.
Crap. Good catch, thanks a lot. Applied and I'll push it to -stable.
prev parent reply other threads:[~2008-08-21 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 20:09 [PATCH] nf_conntrack_sip: fix by making helper pointers thread-local adobriyan
2008-08-21 11:28 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AD5178.4040101@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.