From: Avi Kivity <avi@qumranet.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Chris Wright <chrisw@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] Use .fixup instead of .text.fixup on __kvm_handle_fault_on_reboot
Date: Thu, 21 Aug 2008 16:49:50 +0300 [thread overview]
Message-ID: <48AD727E.4050704@qumranet.com> (raw)
In-Reply-To: <20080819230008.GX6342@blackpad>
Eduardo Habkost wrote:
> [oops. sent it to the old kvm-devel list. sending to the right list, now]
>
> vmlinux.lds expects the fixup code to be on a section named .fixup. The
> .text.fixup section is not mentioned on vmlinux.lds, and is included on
> the resulting vmlinux (just after .text) only because of ld heuristics on
> placing orphan sections.
>
> However, placing .text.fixup outside .text breaks the definition of
> _etext, making it exclude the .text.fixup contents. That makes .text.fixup
> be ignored by the kernel initialization code that needs to know about
> section locations, such as the code setting page protection bits.
>
>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2008-08-21 13:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 23:00 [PATCH] Use .fixup instead of .text.fixup on __kvm_handle_fault_on_reboot Eduardo Habkost
2008-08-21 13:49 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AD727E.4050704@qumranet.com \
--to=avi@qumranet.com \
--cc=chrisw@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.