All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rufus & Azrael <rufus-azrael@numericable.fr>
To: Linux-kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Jan Beulich <jbeulich@novell.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>, Ingo Molnar <mingo@elte.hu>,
	Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: Re:[PATCH] x86-64: fix two modpost warnings in mm/init_64.c
Date: Thu, 21 Aug 2008 16:06:43 +0200	[thread overview]
Message-ID: <48AD7673.1030705@numericable.fr> (raw)


> early_io{re,un}map() are __init and hence can't be called from __meminit
> functions.
> Signed-off-by: Jan Beulich<jbeulich@novell.com>
>
> ---
>   arch/x86/mm/init_64.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> --- linux-2.6.27-rc4/arch/x86/mm/init_64.c	2008-08-21 15:02:41.000000000 +0200
> +++ 2.6.27-rc4-x86_64-modpost-mm-init/arch/x86/mm/init_64.c	2008-08-21 11:49:44.000000000 +0200
> @@ -241,7 +241,7 @@ static unsigned long __initdata table_st
>   static unsigned long __meminitdata table_end;
>   static unsigned long __meminitdata table_top;
>
> -static __meminit void *alloc_low_page(unsigned long *phys)
> +static __ref void *alloc_low_page(unsigned long *phys)
>   {
>   	unsigned long pfn = table_end++;
>   	void *adr;
> @@ -262,7 +262,7 @@ static __meminit void *alloc_low_page(un
>   	return adr;
>   }
>
> -static __meminit void unmap_low_page(void *adr)
> +static __ref void unmap_low_page(void *adr)
>   {
>   	if (after_bootmem)
>   		return;
>
>
>    
Hi Jan,

I have tested your patch, it works fine on my amd64 box and the three 
section mismatches in cause have desapparead.

Thanks and regards.


                 reply	other threads:[~2008-08-21 14:06 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48AD7673.1030705@numericable.fr \
    --to=rufus-azrael@numericable.fr \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.