All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Krivoschekov <dmitry.krivoschekov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Swaminathan S <swami.iyer-l0cyMroinI0@public.gmane.org>
Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org
Subject: Re: Patch [2/2] DaVinci CPPI TX DMA tasklet
Date: Thu, 21 Aug 2008 19:09:26 +0400	[thread overview]
Message-ID: <48AD8526.8080206@gmail.com> (raw)
In-Reply-To: <1219327122-28334-1-git-send-email-swami.iyer-l0cyMroinI0@public.gmane.org>

Hi Swami,

Swaminathan S wrote:
>     Signed-off-by: Swaminathan S <swami.iyer-l0cyMroinI0@public.gmane.org>
>     
>     This patch implements a tasklet to poll for TX Endpoint FIFO
>     empty status before completing a transfer.  This is required
>     in the context of DaVinci CPPI DMA Tx transfers.  CPPI
>     DMA engine generates completion interrupt before the data
>     actually moves out of TX FIFO 

I guess the DMA interrupt is generated after the data have been moved
from a s/w buffer to TX FIFO.
> and the driver needs to save the
>     Data toggle after ensuring that the FIFO is empty.

why don't rely on an endpoint interrupt which is generated after a USB
transaction is complete?


Thanks,
Dmitry



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2008-08-21 15:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 13:58 Patch [2/2] DaVinci CPPI TX DMA tasklet Swaminathan S
2008-08-21 14:25 ` Felipe Balbi
     [not found] ` <1219327122-28334-1-git-send-email-swami.iyer-l0cyMroinI0@public.gmane.org>
2008-08-21 15:09   ` Dmitry Krivoschekov [this message]
2008-08-21 19:15     ` David Brownell
     [not found]       ` <200808211215.37760.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-08-22  1:47         ` Subbrathnam, Swaminathan
     [not found]           ` <FCCFB4CDC6E5564B9182F639FC3560870229F52486-/tLxBxkBPtCIQmiDNMet8wC/G2K4zDHf@public.gmane.org>
2008-08-22  3:24             ` David Brownell
2008-08-22  7:21               ` Felipe Balbi
2008-08-22  1:31     ` Subbrathnam, Swaminathan
2008-08-22  7:23       ` Felipe Balbi
     [not found]         ` <20080822072308.GB9474-f9ZlEuEWxVfta4EC/59zMBl4MBrZKKet0E9HWUfgJXw@public.gmane.org>
2008-08-22  9:12           ` Subbrathnam, Swaminathan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48AD8526.8080206@gmail.com \
    --to=dmitry.krivoschekov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=felipe.balbi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swami.iyer-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.