All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] IDE: compile fix for sff_dma_ops
Date: Fri, 22 Aug 2008 03:28:39 +0400	[thread overview]
Message-ID: <48ADFA27.2070002@ru.mvista.com> (raw)
In-Reply-To: <87bpzm7yoi.fsf@deeprootsystems.com>

Hello.

Kevin Hilman wrote:

>> The sff_dma_ops struct should be wrapped by BLK_DEV_IDEDMA_SFF instead
>> of BLK_DEV_IDEDMA_PCI.
> Oops, I sent the wrong version of this patch.  Here's a better version
> which moves sff_dma_ops into an existing #ifdef block.
>
> Kevin
>
> From d9c182b5109591b9a28384991bcd820554fad371 Mon Sep 17 00:00:00 2001
> From: Kevin Hilman <khilman@deeprootsystems.com>
> Date: Thu, 21 Aug 2008 10:31:44 -0700
> Subject: [PATCH] IDE: compile fix for sff_dma_ops
>
> The sff_dma_ops struct should be wrapped by BLK_DEV_IDEDMA_SFF instead
> of BLK_DEV_IDEDMA_PCI.
>
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
[...]
> diff --git a/include/linux/ide.h b/include/linux/ide.h
> index eb1721c..cf95ca7 100644
> --- a/include/linux/ide.h
> +++ b/include/linux/ide.h
>   
[...]
> @@ -1276,6 +1275,7 @@ int ide_dma_test_irq(ide_drive_t *);
>  extern void ide_dma_lost_irq(ide_drive_t *);
>  extern void ide_dma_timeout(ide_drive_t *);
>  extern const struct ide_dma_ops sff_dma_ops;
> +extern const struct ide_dma_ops sff_dma_ops;
>  #endif /* CONFIG_BLK_DEV_IDEDMA_SFF */

   Somethiung went wrong again.  Do you see what? :-)

MBR, Sergei



  reply	other threads:[~2008-08-21 23:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-21 21:23 [PATCH 1/2] IDE: compile fix for sff_dma_ops Kevin Hilman
2008-08-21 21:23 ` [PATCH 2/2] IDE: palm_bk3710: fix compile warning for unused variable Kevin Hilman
2008-08-25 18:37   ` Bartlomiej Zolnierkiewicz
2008-08-21 23:09 ` [PATCH 1/2] IDE: compile fix for sff_dma_ops Kevin Hilman
2008-08-21 23:28   ` Sergei Shtylyov [this message]
2008-08-21 23:50     ` Kevin Hilman
2008-08-25 18:37       ` Bartlomiej Zolnierkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48ADFA27.2070002@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=khilman@deeprootsystems.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.