From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
JosephChan@via.com.tw
Subject: Re: [PATCH #upstream-fixes] pata_via: clean up recent tf_load changes
Date: Fri, 22 Aug 2008 02:20:27 -0400 [thread overview]
Message-ID: <48AE5AAB.5080507@garzik.org> (raw)
In-Reply-To: <48917FAB.3000703@kernel.org>
Tejun Heo wrote:
> Commit bfce5e0179ad059035df28558724ff60af708e09 implemented custom
> tf_load for pata_via. This patch cleans it up a bit.
>
> * Instead of duplicating whole body, copy tf and set ATA_TFLAG_DEVICE
> when necessary.
>
> * Rename via_ata_tf_load() to via_tf_load().
>
> * No need to set .tf_load in via_port_ops_noirq as it inherits from
> via_port_ops.
>
> * Clean up indentation.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Joseph Chan <JosephChan@via.com.tw>
> ---
> drivers/ata/pata_via.c | 59 +++++++++----------------------------------------
> 1 file changed, 11 insertions(+), 48 deletions(-)
applied
prev parent reply other threads:[~2008-08-22 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 9:02 [PATCH #upstream-fixes] pata_via: clean up recent tf_load changes Tejun Heo
2008-08-22 6:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AE5AAB.5080507@garzik.org \
--to=jeff@garzik.org \
--cc=JosephChan@via.com.tw \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.