From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
piterpunk@slackware.com
Subject: Re: [PATCH #upstream-fixes] ahci: sis controllers actually can do PMP
Date: Fri, 22 Aug 2008 02:20:36 -0400 [thread overview]
Message-ID: <48AE5AB4.9030708@garzik.org> (raw)
In-Reply-To: <4892884F.5000805@kernel.org>
Tejun Heo wrote:
> SIS controllers were blacklisted for PMP as enabling it made device
> detection fail whether the device was PMP or not - the natural
> conclusion was the controller chokes on SRST w/ pmp==15. However, it
> turned out that the controller just didn't like issuing SRST after
> hardreset w/o clearing SError first. Interestingly, the SRST itself
> succeeds but the following commands fail.
>
> If SError is cleared between hardreset and SRST, which is the default
> behavior now, everything works fine and SIS controllers work with PMPs
> happily.
>
> Remove PMP blacklisting for SIS AHCIs.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Piter PUNK <piterpunk@slackware.com>
> ---
> drivers/ata/ahci.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
applied
prev parent reply other threads:[~2008-08-22 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 3:51 [PATCH #upstream-fixes] ahci: sis controllers actually can do PMP Tejun Heo
2008-08-22 6:20 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AE5AB4.9030708@garzik.org \
--to=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=piterpunk@slackware.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.