From: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
To: "Alan D. Brunelle" <Alan.Brunelle@hp.com>
Cc: "Björn Steinbrink" <B.Steinbrink@gmx.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Petr Baudis" <pasky@suse.cz>,
linux-kernel@vger.kernel.org, git@vger.kernel.org
Subject: Re: Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
Date: Fri, 22 Aug 2008 16:17:16 -0400 [thread overview]
Message-ID: <48AF1ECC.7000205@hp.com> (raw)
In-Reply-To: <48AF17C4.4060606@hp.com>
Alan D. Brunelle wrote:
> Björn Steinbrink wrote:
>> On 2008.08.22 10:51:36 -0700, Andrew Morton wrote:
>>> On Fri, 22 Aug 2008 19:16:51 +0200 Petr Baudis <pasky@suse.cz> wrote:
>>>> On Fri, Aug 22, 2008 at 09:25:49AM -0700, Andrew Morton wrote:
>>>>> One (probably wrong) approach is to run
>>>>>
>>>>> gitk 1c89ac55017f982355c7761e1c912c88c941483d
>>>>>
>>>>> then peer at the output, work out which real commits were in that
>>>>> merge.
>>>>>
>>>>> It looks like the merge ended with
>>>>> b1b135c8d619cb2c7045d6ee4e48375882518bb5 and started with
>>>>> 40c42076ebd362dc69210cccea101ac80b6d4bd4, so perhaps you can do
>>>>>
>>>>> git bisect bad b1b135c8d619cb2c7045d6ee4e48375882518bb5
>>>>> git bisect good 40c42076ebd362dc69210cccea101ac80b6d4bd4
>>>> ...I don't quite get this - according to the bisection log,
>>>>
>>>> # good: [b1b135c8d619cb2c7045d6ee4e48375882518bb5] fix spinlock recursion in hvc_console
>>>>
>>>> and now you want to mark it as bad?
>>> <what bisection log?>
>> Alan provided his bisection log as an attachment to the original bug
>> report.
>>
>>> I assume that Alan's bisection search ended up saying that the merge
>>> commit (1c89ac55017f982355c7761e1c912c88c941483d) was the first bad
>>> commit.
>> Yep, and that's totally correct as far as bisect is concerned. The
>> parents of that merge commit are:
>> 88fa08f67bee1a0c765237bdac106a32872f57d2
>> b1b135c8d619cb2c7045d6ee4e48375882518bb5
>>
>> And Alan marked both of them as good.
>>
>> So, unless Alan made a mistake during his bisection, each of the
>> branches is correct, but the merge did not lead to a correct result. So
>> while there were no textual conflicts, there were still incompatible
>> changes regarding the code semantics and compatibility was not restored
>> during the merge.
>
> It's important to note that even if I did make a mistake during the
> bisection process (and I certainly wouldn't discount that), recent
> kernels still fail: but when I take out that commit from a recent
> kernel, it fails.
s/fails/succeeds/
>
> I put in Andrew's suggested patch (to help find things), and now I
> repeatedly get the problems in the attached log.
>
> Not being an x86 knowledgeable person, I'm a bit concerned about the RSP
> value?! (I enabled stack overflow checking, but that didn't stop things.)
>
> Alan
>
next prev parent reply other threads:[~2008-08-22 20:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 23:03 Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected Alan D. Brunelle
2008-08-13 23:27 ` Alan D. Brunelle
2008-08-14 16:14 ` Rafael J. Wysocki
2008-08-14 19:21 ` Alan D. Brunelle
2008-08-14 20:29 ` Rafael J. Wysocki
2008-08-19 19:46 ` Andrew Morton
2008-08-22 15:37 ` Alan D. Brunelle
2008-08-22 16:25 ` Andrew Morton
2008-08-22 17:16 ` Petr Baudis
2008-08-22 17:51 ` Andrew Morton
2008-08-22 18:07 ` Alan D. Brunelle
2008-08-22 19:37 ` Björn Steinbrink
2008-08-22 19:47 ` Alan D. Brunelle
2008-08-22 20:17 ` Alan D. Brunelle [this message]
2008-08-22 19:48 ` Jeff King
2008-08-22 21:05 ` Junio C Hamano
2008-08-22 21:16 ` Andrew Morton
2008-08-22 21:21 ` Jeff King
2008-08-22 21:36 ` Björn Steinbrink
2008-08-25 18:14 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AF1ECC.7000205@hp.com \
--to=alan.brunelle@hp.com \
--cc=B.Steinbrink@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=git@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.