From: Daniel Lezcano <dlezcano@fr.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "Denis V. Lunev" <den@openvz.org>,
davem@davemloft.net, adobriyan@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] icmp: icmp_sk() should not use smp_processor_id() in preemptible code
Date: Sat, 23 Aug 2008 11:12:46 +0200 [thread overview]
Message-ID: <48AFD48E.6050109@fr.ibm.com> (raw)
In-Reply-To: <20080823004849.GA9678@gondor.apana.org.au>
Herbert Xu wrote:
> On Sat, Aug 23, 2008 at 01:15:05AM +0200, Daniel Lezcano wrote:
>> thanks for the fix. For my personal knowledge, why can we just use in
>> the icmp_sk function:
>> {
>> struct sock *isk = net->ipv4.icmp_sk[get_cpu()];
>> put_cpu();
>> return isk;
>> }
>>
>> ?
>
> Because then you can get rescheduled to another CPU while still
> using someone else's ICMP socket.
Obviously :)
Thanks Herbert.
next prev parent reply other threads:[~2008-08-23 9:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 12:20 2.6.27-rc4: icmp_sk() uses smp_processor_id() in preemptible code adobriyan
2008-08-21 12:50 ` Herbert Xu
2008-08-22 11:54 ` David Miller
2008-08-22 13:12 ` Denis V. Lunev
2008-08-22 13:54 ` [PATCH 1/1] icmp: icmp_sk() should not use " Denis V. Lunev
2008-08-22 23:15 ` Daniel Lezcano
2008-08-23 0:48 ` Herbert Xu
2008-08-23 9:12 ` Daniel Lezcano [this message]
2008-08-22 23:21 ` adobriyan
2008-08-23 11:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AFD48E.6050109@fr.ibm.com \
--to=dlezcano@fr.ibm.com \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.