From: Philippe Gerum <rpm@xenomai.org>
To: Jan Kiszka <jan.kiszka@domain.hid>
Cc: Xenomai-core@domain.hid
Subject: Re: [Xenomai-core] [PATCH] Remove redundant LOCK prefix
Date: Sat, 23 Aug 2008 11:58:07 +0200 [thread overview]
Message-ID: <48AFDF2F.7050802@domain.hid> (raw)
In-Reply-To: <48AFCCED.30102@domain.hid>
Jan Kiszka wrote:
> According to Linux and the Intel spec, this prefix is not needed.
>
Obviously, it's not, since the whole purpose of xchg() is to guarantee bus
locking for memory operands anyway. Please merge.
> ---
> include/asm-x86/atomic_32.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/include/asm-x86/atomic_32.h
> ===================================================================
> --- a/include/asm-x86/atomic_32.h
> +++ b/include/asm-x86/atomic_32.h
> @@ -64,7 +64,7 @@ struct __xeno_xchg_dummy { unsigned long
> static inline unsigned long xnarch_atomic_xchg (volatile void *ptr,
> unsigned long x)
> {
> - __asm__ __volatile__(LOCK_PREFIX "xchgl %0,%1"
> + __asm__ __volatile__("xchgl %0,%1"
> :"=r" (x)
> :"m" (*__xeno_xg(ptr)), "0" (x)
> :"memory");
>
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Xenomai-core mailing list
> Xenomai-core@domain.hid
> https://mail.gna.org/listinfo/xenomai-core
--
Philippe.
prev parent reply other threads:[~2008-08-23 9:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-23 8:40 [Xenomai-core] [PATCH] Remove redundant LOCK prefix Jan Kiszka
2008-08-23 9:58 ` Philippe Gerum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48AFDF2F.7050802@domain.hid \
--to=rpm@xenomai.org \
--cc=Xenomai-core@domain.hid \
--cc=jan.kiszka@domain.hid \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.