From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KWqSO-0003ED-NY for mharc-grub-devel@gnu.org; Sat, 23 Aug 2008 06:34:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWqSM-0003DT-4U for grub-devel@gnu.org; Sat, 23 Aug 2008 06:34:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWqSK-0003D9-Jd for grub-devel@gnu.org; Sat, 23 Aug 2008 06:34:53 -0400 Received: from [199.232.76.173] (port=44707 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWqSK-0003D5-GI for grub-devel@gnu.org; Sat, 23 Aug 2008 06:34:52 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:34519 helo=kirsi1.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KWqSJ-0002w7-NY for grub-devel@gnu.org; Sat, 23 Aug 2008 06:34:52 -0400 Received: from [127.0.0.1] (88.193.32.97) by kirsi1.inet.fi (8.5.014) id 487B3C2C019D2345 for grub-devel@gnu.org; Sat, 23 Aug 2008 13:34:47 +0300 Message-ID: <48AFE7D1.3020107@nic.fi> Date: Sat, 23 Aug 2008 13:34:57 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080823101642.GA21564@pina.cat> In-Reply-To: <20080823101642.GA21564@pina.cat> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: GRUB_CONSOLE_KEY_NPAGE/PPAGE codes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Aug 2008 10:34:54 -0000 Carles Pina i Estany wrote: > Hello, > > I started to play with GRUB_TERM_PPAGE/NPAGE in normal/menu.c and I've > had a problem: they was working in opposite way than I've expected. > > Tracing the problem deeper than swapping GRUB_TERM_PPAGE constant by > GRUB_TERM_NPAGE, I have found that this values comes from > GRUB_CONSOLE_KEY_NPAGE. > > Let's define: NPAGE (next page) = PGDN (PG DOWN). PPAGE (previous page) > = PGUP (PG UP). Is this assumption correct? > > There is quite much places in Grub2 code that defines: > #define GRUB_CONSOLE_KEY_NPAGE 0x4900 > #define GRUB_CONSOLE_KEY_PPAGE 0x5100 > > Googling for these codes, I've found that they are usually defined in > opposite way: > #define KEY_PGUP 0x4900 > #define KEY_PGDN 0x5100 > > All other codes matches. > > If this is correct, a bit later I will prepare a patch to swap 0x4900 > and 0x5100 where it's needed. > > Am I missing something? Or me.. couldn't we just use GRUB_CONSOLE_KEY_PAGE_UP / GRUB_CONSOLE_KEY_PAGE_DOWN or something like that. NPAGE or PPAGE seems a bit weird. Then there is no need to hassle this next time when the issue is at hand :)