All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] MIPS: Fix dmtc0 instruction
Date: Sat, 23 Aug 2008 18:42:34 +0200	[thread overview]
Message-ID: <48B03DFA.6080404@reactos.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hi,

In gen_dmtc0 function, TCG temporary variable t0 is freed at the end of
the function. Variable is freed again in the gen_dmtc0 caller.
I removed the free in gen_dmtc0, to do like in gen_dmfc0, gen_mfc0,
gen_mtc0.

Incidentally, this unregresses NetBSD on Pica 61.

Hervé

[-- Attachment #2: dmtc0_fix.diff --]
[-- Type: text/plain, Size: 402 bytes --]

Index: target-mips/translate.c
===================================================================
--- target-mips/translate.c	(revision 5074)
+++ target-mips/translate.c	(working copy)
@@ -5188,7 +5188,6 @@
                 rn, reg, sel);
     }
 #endif
-    tcg_temp_free(t0);
     /* For simplicity assume that all writes can cause interrupts.  */
     if (use_icount) {
         gen_io_end();

             reply	other threads:[~2008-08-23 16:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-23 16:42 Hervé Poussineau [this message]
2008-08-23 17:24 ` [Qemu-devel] [PATCH] MIPS: Fix dmtc0 instruction Aurelien Jarno
2008-08-25 11:28   ` Thiemo Seufer
2008-08-25 12:55     ` Aurelien Jarno
2008-08-25 14:12       ` Thiemo Seufer
2008-08-25 18:51     ` Stefan Weil
2008-08-25 21:10       ` Thiemo Seufer
2008-08-25 22:26         ` Aurelien Jarno
  -- strict thread matches above, loose matches on Subject: below --
2008-08-23 16:40 Hervé Poussineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B03DFA.6080404@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.