From: Benny Halevy <bhalevy@panasas.com>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: Help with compiler warning
Date: Sun, 24 Aug 2008 18:31:44 +0300 [thread overview]
Message-ID: <48B17EE0.2090608@panasas.com> (raw)
In-Reply-To: <48B17E56.3060106@panasas.com>
On Aug. 24, 2008, 18:29 +0300, Benny Halevy <bhalevy@panasas.com> wrote:
> On Aug. 22, 2008, 4:36 +0300, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>> In drivers/pcmcia/cardbus.c, the following statement
>>
>> memcpy_fromio(ptr, s->cb_cis_virt + addr, len);
>>
>> generates the warning
>>
>> CC [M] drivers/pcmcia/cardbus.o
>> include/asm/io_32.h: In function ‘memcpy_fromio’:
>> include/asm/io_32.h:151: warning: passing argument 2 of ‘__memcpy’
>> discards qualifiers from pointer target type
>>
>> s->cb_cis_virt is "void __iomem" and addr is uint.
>>
>> What cast does argument 2 need to silence the warning?
>
> memcpy_fromio takes a (const volatile void __iomem *) for the
> src address.
So the culprit could be the volatile qualifier...
>
> Benny
>
>> Thanks,
>>
>> Larry
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2008-08-24 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 1:36 Help with compiler warning Larry Finger
2008-08-24 15:29 ` Benny Halevy
2008-08-24 15:31 ` Benny Halevy [this message]
2008-08-24 15:50 ` Larry Finger
2008-08-24 16:32 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B17EE0.2090608@panasas.com \
--to=bhalevy@panasas.com \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.