From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KXI9U-0007Ge-3h for mharc-grub-devel@gnu.org; Sun, 24 Aug 2008 12:09:16 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXI9S-0007GZ-D6 for grub-devel@gnu.org; Sun, 24 Aug 2008 12:09:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXI9Q-0007GK-Rq for grub-devel@gnu.org; Sun, 24 Aug 2008 12:09:13 -0400 Received: from [199.232.76.173] (port=58330 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXI9Q-0007GH-NN for grub-devel@gnu.org; Sun, 24 Aug 2008 12:09:12 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:32970 helo=kirsi2.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXI9Q-0007Bb-3W for grub-devel@gnu.org; Sun, 24 Aug 2008 12:09:12 -0400 Received: from [127.0.0.1] (88.193.32.97) by kirsi2.inet.fi (8.5.014) id 488DC54E0128EFB2 for grub-devel@gnu.org; Sun, 24 Aug 2008 19:09:11 +0300 Message-ID: <48B187B4.4000302@nic.fi> Date: Sun, 24 Aug 2008 19:09:24 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: The development of GRUB 2 References: <20080824130216.GA5808@pina.cat> <20080824142944.GA9470@pina.cat> In-Reply-To: <20080824142944.GA9470@pina.cat> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: Quoted-Printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Correcting GRUB_CONSOLE_KEY_NPAGE/PPAGE X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Aug 2008 16:09:14 -0000 Carles Pina i Estany wrote: > I was just thinking... is there any reason that we have the same macros > in 4 different files? >=20 > Why not having just a grub/console_scancodes.h:=20 >=20 > #ifndef GRUB_CONSOLE_SCAN_CODES >=20 > #define GRUB_CONSOLE_KEY_LEFT 0x4B00 > #define GRUB_CONSOLE_KEY_RIGHT 0x4D00 > #define GRUB_CONSOLE_KEY_UP 0x4800 > #define GRUB_CONSOLE_KEY_DOWN 0x5000 > #define GRUB_CONSOLE_KEY_IC 0x5200 > #define GRUB_CONSOLE_KEY_DC 0x5300 > #define GRUB_CONSOLE_KEY_BACKSPACE 0x0008 > #define GRUB_CONSOLE_KEY_HOME 0x4700 > #define GRUB_CONSOLE_KEY_END 0x4F00 > #define GRUB_CONSOLE_KEY_NPAGE 0x5100 > #define GRUB_CONSOLE_KEY_PPAGE 0x4900 >=20 > #endif >=20 > and include this file from the other 4 files? Sounds fine. Why do we have same thing with TERM and CONSOLE? Thanks, Vesa J=E4=E4skel=E4inen