From: Rene Herman <rene.herman@keyaccess.nl>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: Takashi Iwai <tiwai@suse.de>,
Alsa-devel <alsa-devel@alsa-project.org>,
Rene Herman <rene.herman@gmail.com>
Subject: Re: [PATCH] wss_lib: do not mess mixer settings during probe
Date: Sun, 24 Aug 2008 20:36:56 +0200 [thread overview]
Message-ID: <48B1AA48.7020403@keyaccess.nl> (raw)
In-Reply-To: <20080824180804.b88effc0.krzysztof.h1@poczta.fm>
On 24-08-08 18:08, Krzysztof Helt wrote:
> From: Krzysztof Helt <krzysztof.h1@wp.pl>
>
> Use the wss_dout function which does not mess
> shadowed register values during chip probing.
> Otherwise, user ends up with stupid mixer settings
> after driver loading.
>
> Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Acked-by: Rene Herman <rene.herman@gmail.com>
Must say that I only now notice that we're doing that init loop there. I
believe it could be better to introduce an inline __snd_wss_out() with
just the two outb()s and use that from snd_wss_out() and here directly.
And with respect to the mb() ... if anywhere, should't that be between
the two outb's really?
Rene.
next prev parent reply other threads:[~2008-08-24 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-24 16:08 [PATCH] wss_lib: do not mess mixer settings during probe Krzysztof Helt
2008-08-24 18:36 ` Rene Herman [this message]
2008-08-24 19:48 ` Krzysztof Helt
2008-08-24 22:37 ` Rene Herman
2008-08-25 0:23 ` Rene Herman
2008-08-25 5:45 ` Takashi Iwai
2008-08-25 6:19 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B1AA48.7020403@keyaccess.nl \
--to=rene.herman@keyaccess.nl \
--cc=alsa-devel@alsa-project.org \
--cc=krzysztof.h1@poczta.fm \
--cc=rene.herman@gmail.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.