From: Avi Kivity <avi@qumranet.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts
Date: Mon, 25 Aug 2008 13:03:19 +0300 [thread overview]
Message-ID: <48B28367.2040500@qumranet.com> (raw)
In-Reply-To: <20080825093020.GA5617@elte.hu>
Ingo Molnar wrote:
>> I'm a little worried about making emergency restart more complex.
>>
>> Another thing that worries me is that emergency_restart() doesn't
>> reset the box -- it sends INIT. We could do better by using the ACPI
>> FADT reset register (hopefully that's connected to RESET).
>>
>
> reboot was always a bit fragile - i think we should only do that if we
> find a box where the FADT reset works better than the first-wave
> approaches we try.
>
>
It worked on my host. Since it will fall back to keyboard reset and
triple fault, it seems fairly safe.
>> Which seems to be what we want? Maybe we should just try acpi_reboot()
>> before the other stuff.
>>
>
> perhaps in a separate commit, for v2.6.28 at the earliest.
>
I'll send a patch. I don't think my earlier patch is worthwhile as all
machines with VT are acpi capable.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-08-25 10:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 9:11 [PATCH] Fix emergency_restart (sysrq-b) with kvm loaded on Intel hosts Avi Kivity
2008-08-25 9:15 ` Ingo Molnar
2008-08-25 9:27 ` Avi Kivity
2008-08-25 9:30 ` Ingo Molnar
2008-08-25 10:03 ` Avi Kivity [this message]
2008-08-25 10:27 ` Ingo Molnar
2008-08-25 10:36 ` Avi Kivity
2008-08-25 13:12 ` Eric W. Biederman
2008-08-25 13:35 ` Avi Kivity
2008-08-25 13:14 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B28367.2040500@qumranet.com \
--to=avi@qumranet.com \
--cc=ebiederm@xmission.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.