From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [RFC][PATCH 1/3] Move parts of init_dev() into new functions Date: Mon, 25 Aug 2008 19:13:26 -0700 Message-ID: <48B366C6.4010702@zytor.com> References: <20080825201110.GA32440@us.ibm.com> <20080825211146.70b4af63@lxorguk.ukuu.org.uk> <20080825220125.GA1084@us.ibm.com> <48B33072.4080509@zytor.com> <20080825235736.GA2959@us.ibm.com> <48B348A7.5020407@zytor.com> <20080826011807.GB2959@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080826011807.GB2959-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Cc: kyle-hoO6YkzgTuCM0SS3m2neIg@public.gmane.org, bastian-yyjItF7Rl6lg9hUCZPvPmw@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, Alan Cox , ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org sukadev-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org wrote: > > Yes, we know the driver, but do we need to pass it into ->get_tty() ? > > Passing it in (or having the operation compute from inode) has advantage > of allowing drivers to share code if necessary. > Yes, and it gets access to its own data. It's how you implement an object-oriented method call in C. -hpa