From: Tejun Heo <htejun@gmail.com>
To: Gwendal Grignou <gwendal@google.com>
Cc: Artem Bokhan <aptem@ngs.ru>, Jeff Garzik <jeff@garzik.org>,
Mark Lord <liml@rtr.ca>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH #upstream-fixes] sata_mv: don't issue two DMA commands concurrently
Date: Tue, 26 Aug 2008 09:04:31 +0200 [thread overview]
Message-ID: <48B3AAFF.5010704@gmail.com> (raw)
In-Reply-To: <e7510f760808251824m2da1331eq514e864209654028@mail.gmail.com>
Gwendal Grignou wrote:
> What happen if there is a SATA port multiplier behing the marvell
> controller and NCQ is disabled?
>
> I have the impression that with this patch we are able to only send
> one DMA command at a time to all the drives behind the PM, which has
> an impact on performance.
Yeah, right. :-( The simplest way to implement this would be just
calling ata_std_qc_defer() which computes per-link restrictions after
ruling out all non-standard restrictions. I wasn't really sure how
EDMA/NCQ_EN flags are supposed to work so just sticked to the original
condition tests. Mark, can you please help us out here? :-)
Thanks.
--
tejun
next prev parent reply other threads:[~2008-08-26 7:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 10:02 bad sectors, suspicious behaviour Artem Bokhan
2008-08-08 13:34 ` Mark Lord
2008-08-08 13:50 ` Mark Lord
2008-08-08 14:14 ` Mark Lord
2008-08-11 11:12 ` Bokhan Artem
2008-08-13 8:40 ` Tejun Heo
2008-08-13 10:47 ` Artem Bokhan
2008-08-13 10:50 ` Tejun Heo
2008-08-13 11:19 ` Artem Bokhan
2008-08-13 11:24 ` [PATCH #upstream-fixes] sata_mv: don't issue two DMA commands concurrently Tejun Heo
2008-08-13 11:37 ` Artem Bokhan
2008-08-13 11:52 ` Tejun Heo
2008-08-13 12:05 ` Artem Bokhan
2008-08-13 12:21 ` Tejun Heo
2008-08-13 12:32 ` Artem Bokhan
2008-08-13 16:17 ` Mark Lord
2008-08-13 17:37 ` Bokhan Artem
2008-08-13 19:58 ` Bokhan Artem
2008-08-13 23:36 ` Mark Lord
2008-08-14 7:42 ` Artem Bokhan
2008-08-14 12:40 ` Mark Lord
2008-08-14 12:58 ` Artem Bokhan
2008-08-14 13:17 ` Artem Bokhan
2008-08-14 19:49 ` Mark Lord
2008-08-15 5:35 ` Artem Bokhan
2008-08-15 12:27 ` Mark Lord
2008-08-13 16:57 ` Greg Freemyer
2008-08-13 17:29 ` Bokhan Artem
2008-08-13 17:50 ` Greg Freemyer
2008-08-13 18:04 ` Bokhan Artem
2008-08-13 18:13 ` Greg Freemyer
2008-08-13 11:47 ` Artem Bokhan
2008-08-13 11:52 ` Tejun Heo
2008-08-22 16:28 ` Grant Grundler
2008-08-13 16:10 ` Mark Lord
2008-08-22 6:11 ` Jeff Garzik
2008-08-22 17:01 ` Martin Michlmayr
2008-08-26 13:54 ` Mark Lord
2008-08-29 7:12 ` Martin Michlmayr
2008-08-26 1:24 ` Gwendal Grignou
2008-08-26 7:04 ` Tejun Heo [this message]
2008-08-26 13:58 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B3AAFF.5010704@gmail.com \
--to=htejun@gmail.com \
--cc=aptem@ngs.ru \
--cc=gwendal@google.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.