Re: [RFC][PATCH 3/14] memcg: atomic_flags

[Balbir Singh <balbir@linux.vnet.ibm.com>]

kamezawa.hiroyu@jp.fujitsu.com wrote:
> ----- Original Message -----
>> KAMEZAWA Hiroyuki wrote:
>>> This patch makes page_cgroup->flags to be atomic_ops and define
>>> functions (and macros) to access it.
>>>
>>> This patch itself makes memcg slow but this patch's final purpose is 
>>> to remove lock_page_cgroup() and allowing fast access to page_cgroup.
>>>
>> That is a cause of worry, do the patches that follow help performance?
> By applying patchs for this and RCU and removing lock_page_cgroup(), I saw sma
> ll performance benefit.
> 
>> How do we
>> benefit from faster access to page_cgroup() if the memcg controller becomes s
> lower?
> No slow-down on my box but. But the cpu which I'm testing on is a bit old.
> I'd like to try newer CPU.
> As you know, I don't like slow-down very much ;)

I see, yes, I do know that you like to make things faster. BTW, you did not
comment on my comments below about the naming convention and using the __ variants
-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>