From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KXxbl-0006ch-8x
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:25:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KXxbj-0006Zk-H0
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:25:12 -0400
Received: from [199.232.76.173] (port=60945 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KXxbj-0006ZW-6M
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:25:11 -0400
Received: from il.qumranet.com ([212.179.150.194]:51063)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@qumranet.com>) id 1KXxbi-0000B0-Vk
	for qemu-devel@nongnu.org; Tue, 26 Aug 2008 08:25:11 -0400
Message-ID: <48B3F624.2060502@qumranet.com>
Date: Tue, 26 Aug 2008 15:25:08 +0300
From: Avi Kivity <avi@qumranet.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch 1/2] add pci config space struct
References: <48B3DD9E.3060905@redhat.com>
In-Reply-To: <48B3DD9E.3060905@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>   Hi,
>
> This patch adds a struct for the pci config header make it easier to
> deal with it.  Comes from qemu-xen.
>
> cheers,
>   Gerd
>   
> +struct pci_config_header {
> +    uint16_t vendor_id;
> +    uint16_t device_id;
> +    uint16_t command;
> +    uint16_t status;
> +    uint8_t  revision;
> +    uint8_t  api;
> +    uint8_t  subclass;
> +    uint8_t  class;
> +    uint8_t  cache_line_size; /* Units of 32 bit words */
> +    uint8_t  latency_timer;   /* In units of bus cycles */
> +    uint8_t  header_type;     /* Should be 0 */
> +    uint8_t  bist;            /* Built in self test */
> +    uint32_t base_address_regs[6];
> +    uint32_t reserved1;
> +    uint16_t sub_vendor_id;
> +    uint16_t sub_device_id;
> +    uint32_t rom_addr;
> +    uint32_t reserved3;
> +    uint32_t reserved4;
> +    uint8_t  interrupt_line;
> +    uint8_t  interrupt_pin;
> +    uint8_t  min_gnt;
> +    uint8_t  max_lat;
> +};

Shouldn't little-endian types be used here to force the users to use 
little-endian accessors?

-- 
error compiling committee.c: too many arguments to function