All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jens Axboe <jens.axboe@oracle.com>,
	jeff@garzik.org, linux-ide@vger.kernel.org,
	Mark Lord <mlord@pobox.com>, Kay Sievers <kay.sievers@vrfy.org>,
	Gwendal Grignou <gwendal@google.com>
Subject: Re: libata bridge limits
Date: Tue, 26 Aug 2008 14:45:29 +0200	[thread overview]
Message-ID: <48B3FAE9.3040505@kernel.org> (raw)
In-Reply-To: <20080826132547.10955c01@lxorguk.ukuu.org.uk>

Alan Cox wrote:
>>> Now we should probably have a shorter timeout where we then check the
>>> status bits for BUSY so we can quickly catch lost interrupts or commands
>>> but that is quite different.
>> Yeah, we need to check for lost interrupts and dead IRQ due to screaming
>> IRQ.  Maybe we can do some of that in interrupt core.
> 
> For SFF at least we can read altstatus and check for BUSY. If BUSY is not
> set then something is up, either we have an error we didn't get an IRQ
> for or the status is successful.
> 
>> The few I was talking about just freezes the whole machine after a
>> timeout.  Dunno whether the lowlevel driver needs to do EH differently
>> or the controller is just built that way tho.
> 
> Some lock the box solid if you don't reset the controller before you
> touch any registers on a timeout. I thought we had them all covered - do
> you know which controllers are still showing this ?

IIRC some very early via SATAs lock up the machine solid no matter what
you do unless a command is completed by the device side.  Maybe it
requires special sequence to abort in-flight commands but simple SRST
wasn't enough.  :-(

-- 
tejun

  reply	other threads:[~2008-08-26 12:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26  7:28 libata bridge limits Jens Axboe
2008-08-26  9:42 ` Alan Cox
2008-08-26 10:17   ` Jens Axboe
2008-08-26 10:43     ` Tejun Heo
2008-08-26 10:38       ` Alan Cox
2008-08-26 11:23         ` Tejun Heo
2008-08-26 12:25           ` Alan Cox
2008-08-26 12:45             ` Tejun Heo [this message]
2008-08-26 17:25       ` Gwendal Grignou
2008-08-26 17:45         ` James Bottomley
2008-08-26 19:25           ` Gwendal Grignou
2008-08-26 20:55             ` James Bottomley
2008-08-26 12:32     ` Brad Campbell
2008-08-26 12:48       ` Jens Axboe
2008-08-26 12:55         ` Tejun Heo
2008-08-26 13:06           ` Jens Axboe
2008-08-26 13:58             ` Jens Axboe
2008-08-26 14:20               ` Tejun Heo
2008-08-26 14:26                 ` Jens Axboe
2008-08-26 14:25               ` Jens Axboe
2008-08-26 19:36               ` Jeff Garzik
2008-08-26 22:37                 ` Mark Lord
2008-08-27 13:23                 ` Jens Axboe
2008-10-31  5:45                   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B3FAE9.3040505@kernel.org \
    --to=tj@kernel.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=gwendal@google.com \
    --cc=jeff@garzik.org \
    --cc=jens.axboe@oracle.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=mlord@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.