From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KXzwr-0006GC-A8 for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:55:09 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KXzwq-0006Fu-0w for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:55:08 -0400 Received: from [199.232.76.173] (port=39011 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KXzwp-0006Fp-Qe for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:55:07 -0400 Received: from il.qumranet.com ([212.179.150.194]:38275) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KXzwp-0007Hn-AK for qemu-devel@nongnu.org; Tue, 26 Aug 2008 10:55:07 -0400 Message-ID: <48B4194A.20107@qumranet.com> Date: Tue, 26 Aug 2008 17:55:06 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [patch 1/2] add pci config space struct References: <48B3DD9E.3060905@redhat.com> <48B3F624.2060502@qumranet.com> <48B40E60.8090203@redhat.com> In-Reply-To: <48B40E60.8090203@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Gerd Hoffmann wrote: >> Shouldn't little-endian types be used here to force the users to use >> little-endian accessors? >> > > Didn't notice qemu has that. Which header file I should check? There > is nothing in bswap.h ... > I don't think qemu has them; it should though. I'd define le32 (and friends) as a struct to ensure it is impossible to misuse. -- error compiling committee.c: too many arguments to function