From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [RFC][PATCH 1/3] Move parts of init_dev() into new functions Date: Tue, 26 Aug 2008 10:40:36 -0700 Message-ID: <48B44014.2090000@zytor.com> References: <20080825201110.GA32440@us.ibm.com> <20080825211146.70b4af63@lxorguk.ukuu.org.uk> <20080825220125.GA1084@us.ibm.com> <48B33072.4080509@zytor.com> <20080825232003.3574a181@lxorguk.ukuu.org.uk> <48B34818.2000400@zytor.com> <20080826104445.06d36dd2@lxorguk.ukuu.org.uk> <48B431F4.90201@zytor.com> <20080826174921.6bfbf989@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080826174921.6bfbf989-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Alan Cox Cc: kyle-hoO6YkzgTuCM0SS3m2neIg@public.gmane.org, bastian-yyjItF7Rl6lg9hUCZPvPmw@public.gmane.org, containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, xemul-GEFAQzZX7r8dnm+yROfE0A@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org List-Id: containers.vger.kernel.org Alan Cox wrote: > On Tue, 26 Aug 2008 09:40:20 -0700 > "H. Peter Anvin" wrote: > >> Alan Cox wrote: >>> In the case of the initial open you don't yet know the tty pointer and >>> may be creating it. SO the tty isn't a reference because it doesn't exist. >>> >> Got it. I was under the (apparently mistaken) notion that only pty tty >> structures were created dynamically. > > tty is dynamically created and attached to the file handle. The port side > structure is currently port specific and does last. Thats what the > tty_port stuff is intended to slowly standardise but won't help ptys as > they don't have a physical port anyway. > Got it, sorry for the confusion. -hpa