From: Johannes Sixt <j.sixt@viscovery.net>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: GIT Mailing-list <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Steffen Prohaska <prohaska@zib.de>
Subject: Re: [PATCH] Fix a warning (on cygwin) to allow -Werror
Date: Wed, 27 Aug 2008 09:57:36 +0200 [thread overview]
Message-ID: <48B508F0.70402@viscovery.net> (raw)
In-Reply-To: <48B4426D.3090801@ramsay1.demon.co.uk>
Ramsay Jones schrieb:
> Also, I noticed that git_ntohl() is still defined in compat/mingw.h; is this
> still required? It's not a problem, just curious! (I don't have mingw
> installed, so I can't test myself)
Yes, it's still needed. The reason is that on Windows ntohl() returns
'unsigned long', and then gcc warns about
sha1_file.c:700: warning: unsigned int format, u_long arg (arg 3)
git_ntohl() is the workaround.
-- Hannes
next prev parent reply other threads:[~2008-08-27 7:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 17:50 [PATCH] Fix a warning (on cygwin) to allow -Werror Ramsay Jones
2008-08-27 7:57 ` Johannes Sixt [this message]
2008-08-28 16:09 ` Ramsay Jones
2008-08-29 6:23 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B508F0.70402@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=prohaska@zib.de \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.