All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Jay Cliburn <jacliburn@bellsouth.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	link@miggy.org, ian@jeffray.co.uk, csnook@redhat.com,
	jie.yang@atheros.com, m@fhloston.org
Subject: Re: [PATCH] atl1: disable TSO by default
Date: Wed, 27 Aug 2008 05:37:32 -0400	[thread overview]
Message-ID: <48B5205C.9000804@garzik.org> (raw)
In-Reply-To: <20080818192813.0d0dc1fd@osprey.hogchain.net>

Jay Cliburn wrote:
> The atl1 driver is causing stalled connections and file corruption
> whenever TSO is enabled.  Two examples are here:
> 
> http://lkml.org/lkml/2008/7/15/325
> http://lkml.org/lkml/2008/8/18/543
> 
> Disable TSO by default until we can determine the source of the
> problem.
> 
> Signed-off-by: Jay Cliburn <jacliburn@bellsouth.net>
> cc: stable@kernel.org
> ---
> 
> Jeff, I've been trying to find the source of this problem in my
> spare time for a few weeks now, but haven't been successful.  We
> turned on TSO by default in 2.6.26 after fixing a nasty performance
> bug in it, but there's apparently another bug lurking.
> 
> This patch needs to be also applied to 2.6.26, hence the cc to
> stable.
> 
>  drivers/net/atlx/atl1.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)

applied



      parent reply	other threads:[~2008-08-27  9:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19  0:28 [PATCH] atl1: disable TSO by default Jay Cliburn
2008-08-19 13:10 ` Herbert Xu
2008-08-19 22:53   ` Jay Cliburn
2008-08-19 22:58     ` David Miller
2008-08-19 23:17       ` Herbert Xu
2008-08-27  9:37 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B5205C.9000804@garzik.org \
    --to=jeff@garzik.org \
    --cc=csnook@redhat.com \
    --cc=ian@jeffray.co.uk \
    --cc=jacliburn@bellsouth.net \
    --cc=jie.yang@atheros.com \
    --cc=link@miggy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m@fhloston.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.