From: Jeff Garzik <jeff@garzik.org>
To: Santiago Leon <santil@us.ibm.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ibmveth: fix bad UDP checksums
Date: Wed, 27 Aug 2008 05:37:49 -0400 [thread overview]
Message-ID: <48B5206D.2010502@garzik.org> (raw)
In-Reply-To: <20080820190826.24896.41095.62294@soporte.mitelefono.ec>
Santiago Leon wrote:
> This patch fixes a ibmveth bug where bad UDP checksums are being transmitted
> when checksum offloading is enabled.
> The hypervisor does checksum offloading only on TCP packets, so ibmveth calls
> skb_checksum_help() for any other protocol. The bug happens because
> the packet is being modified after the DMA map, so we would need a memory
> barrier before making the hypervisor call. Reordering the code so that the
> DMA map happens after skb_checksum_help() has the additional advantage of
> fixing a DMA map leak if skb_checksum_help() where to fail.
>
> Please consider applying.
>
> Signed-off-by: Santiago Leon <santil@us.ibm.com>
> ---
>
> ibmveth.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
applied
prev parent reply other threads:[~2008-08-27 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 19:09 [PATCH] ibmveth: fix bad UDP checksums Santiago Leon
2008-08-21 19:41 ` Brian King
2008-08-27 9:37 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B5206D.2010502@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=santil@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.