All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffman <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH][RFC] Use signalfd() to work around signal/select race
Date: Wed, 27 Aug 2008 09:06:17 -0500	[thread overview]
Message-ID: <48B55F59.303@us.ibm.com> (raw)
In-Reply-To: <18613.9097.941852.329602@mariner.uk.xensource.com>

Ian Jackson wrote:
> Anthony Liguori writes ("[PATCH][RFC] Use signalfd() to work around signal/select race"):
>   
>> Here's my patch to work around the signal/select race.  I think it cleans up
>> the code quite nicely.  While signalfd() is Linux-bias, I think it's a nice
>> interface and the emulation isn't too bad.
>>
>> I've only lightly tested.  I'm looking to see what people's reaction would be
>> to this.
>>     
>
> For the avoidance of any doubt, following my criticisms of Anthony's
> approach: I think it's essential that we have at least one of
> Anthony's or my fixes to this problem.
>
> Obviously I prefer my patch because I wrote it, but other people might
> prefer it because it's textually much smaller, closer to the existing
> code, and doesn't use threads.
>
> Also, my patch has been pretty thoroughly tested, including some
> performance stress testing, as part of the Xen 3.3.0 release.
>   

FWIW, I still don't see your patch.  It's not on gmane so I don't think 
it's a problem on my side.

Regards,

Anthony Liguori

> Ian.
>   

  reply	other threads:[~2008-08-27 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 20:44 [Qemu-devel] [PATCH][RFC] Use signalfd() to work around signal/select race Anthony Liguori
2008-08-27  9:51 ` [Qemu-devel] " Ian Jackson
2008-08-27 14:06   ` Anthony Liguori [this message]
2008-08-27 14:44     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B55F59.303@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.