All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joshua Brindle <jbrindle@tresys.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Ivan Gyurdiev <ivg231@gmail.com>,
	Daniel J Walsh <dwalsh@redhat.com>,
	SE Linux <selinux@tycho.nsa.gov>
Subject: Re: libsemage patch to not compile modules for seusers and fcontext
Date: Wed, 27 Aug 2008 18:44:36 -0400	[thread overview]
Message-ID: <48B5D8D4.8010502@tresys.com> (raw)
In-Reply-To: <1219838648.5708.10.camel@moss-spartans.epoch.ncsc.mil>

Stephen Smalley wrote:
> On Tue, 2008-08-26 at 21:52 -0400, Ivan Gyurdiev wrote:
>>>> I'm a little unclear on what this is doing - can you clarify?
>>>>     
>>> This is clearing the existing seusers.final file, otherwise delete was
>>> not working.
>>>   
>> I think the previous code was doing more - it was merging the local file 
>> with the shipped base package file, like this:
>>
>>     data = extract_file_from_policy_package( )
>>     write_file ( "seusers.final", data )
>>     if ( data != null ) {
>>         seusers.clear_cache()  // thereby forcing reload from 
>> seusers.final when cache() is called again (in merge_components)
>>     } else {
>>         seusers.clear()
>>     }
>>
>> It's also doing this three times (once for fcontexts, once for seusers, 
>> once for seusers_extra).
>> The problem is that you're skipping the link_sandbox call, which builds 
>> the base package, containing this information.
> 
> We're trying to avoid the overhead of re-linking the policy when we are
> only modifying non-policy components like seusers and fcontexts.
> fcontexts.local is split out to a separate file for precedence reasons
> so it doesn't get merged anymore.  I don't think Dan actually uses
> seusers in the base policy for anything at present, but others may be.
> 

Verified. The seusers coming from the policy are not merged into the seusers.final with this patchset. 

It appears that at present in sepol_link_packages() there is no merging of seusers from each module so we only support seusers in base presently. Therefore we don't have to worry about getting the seusers from all the modules but we do need to grab them out of the base module and combine them in.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2008-08-27 22:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-14 19:46 libsemage patch to not compile modules for seusers and fcontext Daniel J Walsh
2008-08-15  1:38 ` Ivan Gyurdiev
2008-08-22 13:38 ` Stephen Smalley
2008-08-26 15:11   ` Daniel J Walsh
2008-08-26 15:28     ` Joshua Brindle
2008-08-26 17:26       ` Daniel J Walsh
2008-08-26 18:42         ` Joshua Brindle
2008-08-27  1:52     ` Ivan Gyurdiev
2008-08-27 12:04       ` Stephen Smalley
2008-08-27 22:44         ` Joshua Brindle [this message]
2008-08-27 22:55           ` Joshua Brindle
2008-09-04 15:16           ` Joshua Brindle
2008-09-04 19:16             ` Daniel J Walsh
2008-09-05  2:52               ` Ivan Gyurdiev
2008-09-10 14:30       ` Daniel J Walsh
2008-09-11  3:08         ` Ivan Gyurdiev
2008-09-12 18:53         ` Joshua Brindle
2008-09-15 12:53           ` Daniel J Walsh
2008-09-15 15:59         ` Joshua Brindle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B5D8D4.8010502@tresys.com \
    --to=jbrindle@tresys.com \
    --cc=dwalsh@redhat.com \
    --cc=ivg231@gmail.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.