All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] ACPI: thinkpad-acpi: wan radio control is not experimental
Date: Wed, 27 Aug 2008 21:04:49 -0700	[thread overview]
Message-ID: <48B623E1.3010508@goop.org> (raw)
In-Reply-To: <20080828014647.GA24365@khazad-dum.debian.net>

The WWAN radio control has been working well for over three years,
and is no longer experimental.

Signed-off-by: Jeremy Fitzhardinge <jeremy@goop.org>
---
 Documentation/laptops/thinkpad-acpi.txt |   11 +++--------
 drivers/misc/thinkpad_acpi.c            |    1 -
 2 files changed, 3 insertions(+), 9 deletions(-)

===================================================================
--- a/Documentation/laptops/thinkpad-acpi.txt
+++ b/Documentation/laptops/thinkpad-acpi.txt
@@ -44,7 +44,7 @@
 	- LCD brightness control
 	- Volume control
 	- Fan control and monitoring: fan speed, fan enable/disable
-	- Experimental: WAN enable and disable
+	- WAN enable and disable
 
 A compatibility table by model and feature is maintained on the web
 site, http://ibm-acpi.sf.net/. I appreciate any success or failure
@@ -1375,17 +1375,12 @@
 would be the safest choice, though).
 
 
-EXPERIMENTAL: WAN
------------------
+WAN
+---
 
 procfs: /proc/acpi/ibm/wan
 sysfs device attribute: wwan_enable (deprecated)
 sysfs rfkill class: switch "tpacpi_wwan_sw"
-
-This feature is marked EXPERIMENTAL because the implementation
-directly accesses hardware registers and may not work as expected. USE
-WITH CAUTION! To use this feature, you need to supply the
-experimental=1 parameter when loading the module.
 
 This feature shows the presence and current state of a W-WAN (Sierra
 Wireless EV-DO) device.
===================================================================
--- a/drivers/misc/thinkpad_acpi.c
+++ b/drivers/misc/thinkpad_acpi.c
@@ -3086,7 +3086,6 @@
 	.read = wan_read,
 	.write = wan_write,
 	.exit = wan_exit,
-	.flags.experimental = 1,
 };
 
 /*************************************************************************



  reply	other threads:[~2008-08-28  4:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 22:11 /proc/acpi/ibm/wan stopped appearing Jeremy Fitzhardinge
2008-08-27 23:12 ` Henrique de Moraes Holschuh
2008-08-27 23:27   ` Jeremy Fitzhardinge
2008-08-28  1:46     ` Henrique de Moraes Holschuh
2008-08-28  4:04       ` Jeremy Fitzhardinge [this message]
2008-08-28 13:39         ` [PATCH] ACPI: thinkpad-acpi: wan radio control is not experimental Henrique de Moraes Holschuh
2008-08-28 17:25         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B623E1.3010508@goop.org \
    --to=jeremy@goop.org \
    --cc=hmh@hmh.eng.br \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.