From: Avi Kivity <avi@qumranet.com>
To: Mohammed Gamal <m.gamal005@gmail.com>
Cc: kvm@vger.kernel.org, riel@surriel.com
Subject: Re: [PATCH][RESEND] kvm: testsuite: Consolidate mov r, imm testing in one function
Date: Thu, 28 Aug 2008 19:05:07 +0300 [thread overview]
Message-ID: <48B6CCB3.5070900@qumranet.com> (raw)
In-Reply-To: <20080827145736.GA7140@mohd-laptop>
Mohammed Gamal wrote:
> Consolidate mov r, imm testing in one function
>
>
Doesn't apply, likely due to coding style fixes I made to the previous
patch.
> - if(!regs_equal(&inregs, &outregs, R_AX) || outregs.eax != 1234567890)
> + if(!regs_equal(inregs, outregs, R_AX) || outregs->eax != 1234567890)
>
"if _nospace_ (" hurts my eyes. I find it really confusing. Please
avoid it.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2008-08-28 16:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-27 14:57 [PATCH][RESEND] kvm: testsuite: Consolidate mov r, imm testing in one function Mohammed Gamal
2008-08-28 16:05 ` Avi Kivity [this message]
2008-08-28 16:40 ` Mohammed Gamal
2008-08-28 17:02 ` Mohammed Gamal
2008-08-29 11:33 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B6CCB3.5070900@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=m.gamal005@gmail.com \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.