All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yu Zhiguo <yuzg@cn.fujitsu.com>
To: Steve Grubb <sgrubb@redhat.com>
Cc: audit-list <linux-audit@redhat.com>
Subject: [PATCH] delete redundant info from result of 'auditctl -l'
Date: Fri, 29 Aug 2008 16:55:47 +0800	[thread overview]
Message-ID: <48B7B993.7000700@cn.fujitsu.com> (raw)

Hello steve,

The field of 'syscall=all' is redundant for fielter 'exclude',
so it should be deleted, e.g.
  # auditctl -l
  LIST_RULES: exclude,always syscall=all

should be:
  LIST_RULES: exclude,always

Signed-off-by: Yu Zhiguo<yuzg@cn.fujitsu.com>
---
 src/auditctl.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/auditctl.c b/src/auditctl.c
index 70a54f3..60c2a80 100644
--- a/src/auditctl.c
+++ b/src/auditctl.c
@@ -1424,7 +1424,9 @@ static int audit_print_reply(struct audit_reply *rep)
 				((rep->rule->flags & AUDIT_FILTER_MASK) != 
 						AUDIT_FILTER_USER) &&
 				((rep->rule->flags & AUDIT_FILTER_MASK) !=
-						AUDIT_FILTER_TASK)) {
+						AUDIT_FILTER_TASK) &&
+				((rep->rule->flags & AUDIT_FILTER_MASK) !=
+						AUDIT_FILTER_EXCLUDE)) {
 				printf(" syscall=");
 				for (sparse = 0, i = 0; 
 					i < (AUDIT_BITMASK_SIZE-1); i++) {
-- 
1.5.4.2

             reply	other threads:[~2008-08-29  8:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29  8:55 Yu Zhiguo [this message]
2008-08-29 14:52 ` [PATCH] delete redundant info from result of 'auditctl -l' Steve Grubb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48B7B993.7000700@cn.fujitsu.com \
    --to=yuzg@cn.fujitsu.com \
    --cc=linux-audit@redhat.com \
    --cc=sgrubb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.