From: Marek Zawirski <marek.zawirski@gmail.com>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>, git@vger.kernel.org
Subject: Re: [JGIT PATCH] Disambiguate "push not supported" from "repository not found"
Date: Fri, 29 Aug 2008 14:18:47 +0200 [thread overview]
Message-ID: <48B7E927.2000205@gmail.com> (raw)
In-Reply-To: <200808291120.44413.robin.rosenberg@dewire.com>
Robin Rosenberg wrote:
> fredagen den 29 augusti 2008 02.18.38 skrev Shawn O. Pearce:
>> + if (avail.isEmpty())
>> + throw noRepository();
>> throw eof;
>> }
>>
>> @@ -185,6 +182,10 @@ else if (this instanceof FetchConnection)
>> available(avail);
>> }
>>
>> + protected TransportException noRepository() {
>> + return new NoRemoteRepositoryException(uri, "not found.");
>> + }
>> +
>
> Why an extra method for instantiating the exception?
Isn't it overrode in subclass - BasePackPushConnection?
--
Marek Zawirski [zawir]
marek.zawirski@gmail.com
next prev parent reply other threads:[~2008-08-29 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 0:18 [JGIT PATCH] Disambiguate "push not supported" from "repository not found" Shawn O. Pearce
2008-08-29 9:20 ` Robin Rosenberg
2008-08-29 12:18 ` Marek Zawirski [this message]
2008-08-29 14:31 ` Shawn O. Pearce
2008-08-31 8:28 ` Robin Rosenberg
2008-09-02 5:42 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B7E927.2000205@gmail.com \
--to=marek.zawirski@gmail.com \
--cc=git@vger.kernel.org \
--cc=robin.rosenberg@dewire.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.