From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KZ5QL-0004ca-K0 for mharc-grub-devel@gnu.org; Fri, 29 Aug 2008 10:58:05 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KZ5QJ-0004Zm-FB for grub-devel@gnu.org; Fri, 29 Aug 2008 10:58:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KZ5QH-0004Yu-FP for grub-devel@gnu.org; Fri, 29 Aug 2008 10:58:02 -0400 Received: from [199.232.76.173] (port=55986 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KZ5QH-0004Ya-7e for grub-devel@gnu.org; Fri, 29 Aug 2008 10:58:01 -0400 Received: from mta-out.inet.fi ([195.156.147.13]:36982 helo=kirsi1.inet.fi) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KZ5QG-0005mJ-Km for grub-devel@gnu.org; Fri, 29 Aug 2008 10:58:01 -0400 Received: from [127.0.0.1] (88.193.32.97) by kirsi1.inet.fi (8.5.014) id 48B55E9A001F1BED for grub-devel@gnu.org; Fri, 29 Aug 2008 17:57:59 +0300 Message-ID: <48B80E7E.1070300@nic.fi> Date: Fri, 29 Aug 2008 17:58:06 +0300 From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: The development of GRUB 2 References: <87d4jsgfpz.fsf@xs4all.nl> In-Reply-To: <87d4jsgfpz.fsf@xs4all.nl> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: Quoted-Printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: Handlers X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Aug 2008 14:58:04 -0000 Marco Gerards wrote: > This patch adds handler support to GRUB 2. This makes it easier to > add new handlers to GRUB without duplicating code over and over. Bean > wanted this for some of his ideas :-) >=20 > Okuji (and others), can you please review this patch? It is an > intrusive (but yet small!) change of which I hope most people agree > with. I just don't want to commit this without proper review. Hi, Just from previous experience with macros... it dam hard to debug with them when you are using debugger. SO... if you can avoid that please do it that way. Can you try to think alternative version without using macro= s? Thanks, Vesa J=E4=E4skel=E4inen