From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: Re: [PATCH] constify microcode hypercall argument
Date: Fri, 29 Aug 2008 15:28:23 +0100
Message-ID: <48B823A7.76E4.0078.0@novell.com>
References: <48B808A4.76E4.0078.0@novell.com>
	<200808291555.03806.Christoph.Egger@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <200808291555.03806.Christoph.Egger@amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> Christoph Egger <Christoph.Egger@amd.com> 29.08.08 15:55 >>>
>On Friday 29 August 2008 14:33:08 Jan Beulich wrote:
>> Linux 2.6.27 marks the data pointer in its firmware struct 'const', and
>> hence, to avoid a compiler warning, Xen's microcode update interface
>> should be properly properly constified too.
>
>What makes you confident, that this reason applies to other operating =
systems
>(Solaris, BSD) , too ?

Adding 'const' on the consumer side is always safe, as long as the =
consumer
guarantees it won't violate the promise. The consumer here is Xen, so
there are no worries about individual guest OSes.

Jan