From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Milburn <dmilburn@redhat.com>,
jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_sil680: remove duplicate pcim_enable_device
Date: Sat, 30 Aug 2008 13:09:01 +0200 [thread overview]
Message-ID: <48B92A4D.3050801@kernel.org> (raw)
In-Reply-To: <20080829165024.6d2ff573@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Fri, 29 Aug 2008 10:36:28 -0500
> David Milburn <dmilburn@redhat.com> wrote:
>
>> Remove duplicate call to pcim_enable_device in sil680_init_one.
>>
>> Signed-off-by: David Milburn <dmilburn@redhat.com>
>
> Acked-by: Alan Cox <alan@redhat.com>
>
> Doh.. ;)
Doh... was that me? Going through the log... Yay, it was me in the
commit f08048e94564d009b19038cfbdd800aa83e79c7f. Lucky me. I was
supposed to move enabling above but apparently forgot to killing the
original one. Heh... anyways. Thanks for spotting this.
Embarrassingly-Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
next prev parent reply other threads:[~2008-08-30 11:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 15:36 [PATCH] pata_sil680: remove duplicate pcim_enable_device David Milburn
2008-08-29 15:50 ` Alan Cox
2008-08-30 11:09 ` Tejun Heo [this message]
2008-09-08 16:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48B92A4D.3050801@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dmilburn@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.