From: Avi Kivity <avi@qumranet.com>
To: yasker@gmail.com
Cc: kvm@vger.kernel.org, Sheng Yang <sheng.yang@intel.com>
Subject: Re: [PATCH] KVM: MMU: Add shadow_accessed_shift
Date: Sun, 31 Aug 2008 18:13:54 +0300 [thread overview]
Message-ID: <48BAB532.2010701@qumranet.com> (raw)
In-Reply-To: <1220113098-25053-1-git-send-email-sheng.yang@intel.com>
yasker@gmail.com wrote:
> From: Sheng Yang <sheng.yang@intel.com>
>
> We use a "fake" A/D bit for EPT, to keep epte behaviour consistent with shadow
> spte. But it's not that good for MMU notifier. Now we can only expect return
> young=0 for clean_flush_young() in most condition.
>
>
Perhaps we are better off setting shadow_accessed_mask to 0 for ept, and
adding a test for clear_flush_young()? This is the only place that
needs adjusting as far as I can tell.
I don't see what having a fake accessed bit buys us, and I'd like the
patch to be as small as possible, since it needs to go into
2.6.26-stable and 2.6.27-rc.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-08-31 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 16:18 [PATCH] KVM: MMU: Add shadow_accessed_shift yasker
2008-08-31 15:13 ` Avi Kivity [this message]
2008-09-01 5:39 ` Yang, Sheng
-- strict thread matches above, loose matches on Subject: below --
2008-08-29 7:28 Yang, Sheng
2008-08-29 11:49 ` Avi Kivity
2008-08-29 13:19 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BAB532.2010701@qumranet.com \
--to=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
--cc=sheng.yang@intel.com \
--cc=yasker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.