From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KZpiv-0005WU-Qh
	for mharc-grub-devel@gnu.org; Sun, 31 Aug 2008 12:24:21 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KZpiu-0005WD-Dr
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:24:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KZpiu-0005W1-0r
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:24:20 -0400
Received: from [199.232.76.173] (port=56934 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KZpit-0005Vy-RO
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:24:19 -0400
Received: from mta-out.inet.fi ([195.156.147.13]:47383 helo=kirsi1.inet.fi)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <chaac@nic.fi>) id 1KZpit-0000Xm-LU
	for grub-devel@gnu.org; Sun, 31 Aug 2008 12:24:20 -0400
Received: from [127.0.0.1] (88.193.32.97) by kirsi1.inet.fi (8.5.014)
	id 48B55E9A0031C81A for grub-devel@gnu.org;
	Sun, 31 Aug 2008 19:24:18 +0300
Message-ID: <48BAC5BF.8050600@nic.fi>
Date: Sun, 31 Aug 2008 19:24:31 +0300
From: =?ISO-8859-1?Q?Vesa_J=E4=E4skel=E4inen?= <chaac@nic.fi>
User-Agent: Thunderbird 2.0.0.16 (Windows/20080708)
MIME-Version: 1.0
To: The development of GRUB 2 <grub-devel@gnu.org>
References: <20080831000157.0c548199@gamma.lan> <48BAC517.4060002@nic.fi>
In-Reply-To: <48BAC517.4060002@nic.fi>
X-Enigmail-Version: 0.95.7
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: Quoted-Printable
X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3)
Subject: Re: [PATCH] GSoC #09 Bitmap scaling
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Aug 2008 16:24:20 -0000

Vesa J=E4=E4skel=E4inen wrote:
> Colin D Bennett wrote:
>> This patch adds image scaling support.  Nearest neighbor and bilinear
>> interpolation algorithms are supported.
>>
>> The gfxterm background_image command scales the background image to fi=
t
>> the screen.  This can be controlled with the new --mode/-m option.
>=20
> Copyrights years for new files seems wrong
>=20
> It is really necessary that all generic graphical menu code like bitmap
> scaler works always. Not just for some optimized formats as otherwise i=
t
> would render graphical menu unusable in some cases. It can be not so
> pretty on low end systems, but it should at least work. That is the
> reason there is map/unmap functions in video api.
>=20
> So there has to be first generic implementation and then you can use
> optimized one if there exist one.
>=20
> Basically I have not bothered to go formats below 1 byte. But obviously
> as there is now 1 bit format that needs to be supported too.
>=20
> Perhaps there should be set/getpixel for bitmap or so. I do not want
> those to appear in video drivers thou at least as external.

Oh one extra thing. I would like that only create_scaled is visible out
side as accessible function. So this would only provide one easy entry
point for such functionality.

I am just wondering do we have module globals that are not exported
outside...