From: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
To: linux-hotplug@vger.kernel.org
Subject: [PATCH] Some function locals in udev_rules_parse.c were needlessly
Date: Sun, 31 Aug 2008 17:30:49 +0000 [thread overview]
Message-ID: <48BAD549.6080304@tuffmail.co.uk> (raw)
This does not affect current behaviour. However, it is required to
make the functions thread-safe. (I'm playing with a threaded udevd).
Signed-off-by: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
diff --git a/udev/udev_rules_parse.c b/udev/udev_rules_parse.c
index 705b3fe..90b139b 100644
--- a/udev/udev_rules_parse.c
+++ b/udev/udev_rules_parse.c
@@ -41,7 +41,7 @@ void udev_rules_iter_init(struct udev_rules *rules)
struct udev_rule *udev_rules_iter_next(struct udev_rules *rules)
{
- static struct udev_rule *rule;
+ struct udev_rule *rule;
if (!rules)
return NULL;
@@ -61,7 +61,7 @@ struct udev_rule *udev_rules_iter_next(struct udev_rules *rules)
struct udev_rule *udev_rules_iter_label(struct udev_rules *rules, const char *label)
{
- static struct udev_rule *rule;
+ struct udev_rule *rule;
size_t start = rules->current;
next:
next reply other threads:[~2008-08-31 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-31 17:30 Alan Jenkins [this message]
2008-09-01 14:32 ` [PATCH] Some function locals in udev_rules_parse.c were needlessly declared as static Kay Sievers
2008-09-01 17:37 ` [PATCH] Some function locals in udev_rules_parse.c were needlessly Alan Jenkins
2008-09-01 17:50 ` [PATCH] Some function locals in udev_rules_parse.c were Kay Sievers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BAD549.6080304@tuffmail.co.uk \
--to=alan-jenkins@tuffmail.co.uk \
--cc=linux-hotplug@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.