All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@nokia.com>
To: "ext Aguirre Rodriguez, Sergio Alberto" <saaguirre@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 4/15] OMAP3 camera driver: V4L2: Add VIDIOC_G_PRIV_MEM
Date: Mon, 01 Sep 2008 10:28:25 +0300	[thread overview]
Message-ID: <48BB9999.4090504@nokia.com> (raw)
In-Reply-To: <A24693684029E5489D1D202277BE89441191E325@dlee02.ent.ti.com>

ext Aguirre Rodriguez, Sergio Alberto wrote:
> From: Sakari Ailus <sakari.ailus@nokia.com>
> Subject: [PATCH] V4L: Add VIDIOC_G_PRIV_MEM
> 
> Some devices, for example image sensors, contain settings in their
> EEPROM memory that are useful to userspace programs. VIDIOC_G_PRIV_MEM
> can be used to read those settings.
> 
> This patch adds also the corresponding v4l2_int_device command.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@nokia.com>

...

> @@ -1423,8 +1430,9 @@
>  #define	VIDIOC_DBG_G_REGISTER 	_IOWR('V', 80, struct v4l2_register)
>  
>  #define VIDIOC_G_CHIP_IDENT     _IOWR('V', 81, struct v4l2_chip_ident)
> +#define VIDIOC_G_PRIV_MEM       _IOWR('V', 82, struct v4l2_priv_mem)
>  #endif
> -#define VIDIOC_S_HW_FREQ_SEEK	 _IOW('V', 82, struct v4l2_hw_freq_seek)
> +#define VIDIOC_S_HW_FREQ_SEEK	 _IOW('V', 83, struct v4l2_hw_freq_seek)

Ouch. You can't do that! :)

(I don't think this was part of my original patch.)

-- 
Sakari Ailus
sakari.ailus@nokia.com

  reply	other threads:[~2008-09-01  7:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 23:25 [PATCH 4/15] OMAP3 camera driver: V4L2: Add VIDIOC_G_PRIV_MEM Aguirre Rodriguez, Sergio Alberto
2008-09-01  7:28 ` Sakari Ailus [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-08-29 23:38 Aguirre Rodriguez, Sergio Alberto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BB9999.4090504@nokia.com \
    --to=sakari.ailus@nokia.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=saaguirre@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.