All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	dm-devel@redhat.com
Subject: Re: [PATCH #blk-for-2.8] init: DEBUG_BLOCK_EXT_DEVT requires explicit root= param
Date: Mon, 01 Sep 2008 13:20:58 +0200	[thread overview]
Message-ID: <48BBD01A.7000603@kernel.org> (raw)
In-Reply-To: <20080901111635.GN20055@kernel.dk>

Jens Axboe wrote:
>> There are other ways to specify device numbers directly (ie. root=8:0)
>> and DEBUG_BLOCK_EXT_DEVT being a debug option I don't think it
>> warrants a complex logic, so I just added simple warning message.
> 
> How about just putting that in the help entry as well? Given that it's
> now defaulting to 'n', people that enable it should read the help text
> anyway.

I'll add that to help message but I still think it'll be beneficial to
have warning message printed to avoid getting people off guard. e.g.
alpha/beta distro built with the debug option turned on to detect bugs.

Thanks.

-- 
tejun

  reply	other threads:[~2008-09-01 11:20 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27  8:34 linux-next: Tree for August 27 Stephen Rothwell
2008-08-27 10:06 ` Bartlomiej Zolnierkiewicz
2008-08-27 14:57   ` Bartlomiej Zolnierkiewicz
2008-08-27 19:45     ` Bartlomiej Zolnierkiewicz
2008-08-29  0:10       ` Bartlomiej Zolnierkiewicz
2008-08-29  7:05         ` Jens Axboe
2008-08-29  8:36           ` Stephen Rothwell
2008-08-29  9:35           ` [PATCH] block: don't test for partition size in bdget_disk() and blk_lookup_devt() Tejun Heo
2008-08-29  9:37           ` linux-next: Tree for August 27 Tejun Heo
2008-08-29  9:42             ` Jens Axboe
2008-08-29 19:23               ` Bartlomiej Zolnierkiewicz
2008-08-30  9:10                 ` Tejun Heo
2008-08-31 13:38                   ` Bartlomiej Zolnierkiewicz
2008-09-01 11:00                     ` [PATCH #blk-for-2.8] init: DEBUG_BLOCK_EXT_DEVT requires explicit root= param Tejun Heo
2008-09-01 11:16                       ` Jens Axboe
2008-09-01 11:20                         ` Tejun Heo [this message]
2008-09-01 11:30                           ` Jens Axboe
2008-09-01 11:38                             ` Tejun Heo
2008-09-01 16:34                               ` Bartlomiej Zolnierkiewicz
2008-08-28  1:25     ` linux-next: Tree for August 27 Stephen Rothwell
2008-08-28  9:08     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BBD01A.7000603@kernel.org \
    --to=tj@kernel.org \
    --cc=bzolnier@gmail.com \
    --cc=dm-devel@redhat.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.