From: Avi Kivity <avi@qumranet.com>
To: Alexander Graf <agraf@suse.de>
Cc: kvm@vger.kernel.org, joro@8bytes.org, anthony@codemonkey.ws
Subject: Re: [PATCH 2/2] Allow the SVM CPUID bit in a VM
Date: Mon, 01 Sep 2008 17:00:16 +0300 [thread overview]
Message-ID: <48BBF570.9070301@qumranet.com> (raw)
In-Reply-To: <1220270342-15769-3-git-send-email-agraf@suse.de>
Alexander Graf wrote:
> Usually the qemu-kvm-bridge removes the SVM capability flag. Since KVM now
> supports nested SVM, this is no longer necessary.
>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> qemu/qemu-kvm-x86.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/qemu/qemu-kvm-x86.c b/qemu/qemu-kvm-x86.c
> index 5daedd1..cfc533f 100644
> --- a/qemu/qemu-kvm-x86.c
> +++ b/qemu/qemu-kvm-x86.c
> @@ -489,9 +489,6 @@ static void do_cpuid_ent(struct kvm_cpuid_entry *e, uint32_t function,
> // nx
> if ((h_edx & 0x00100000) == 0)
> e->edx &= ~0x00100000u;
> - // svm
> - if (e->ecx & 4)
> - e->ecx &= ~4u;
> }
>
Needs to be predicated on a KVM_CAP_ test, so we don't enable this on
older kvms.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2008-09-01 14:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-01 11:59 [PATCH 0/2] [RFC] Add support for nested SVM (userspace) Alexander Graf
2008-09-01 11:59 ` [PATCH 1/2] Add SVM CPUID feature define for backwards compatibility Alexander Graf
2008-09-01 11:59 ` [PATCH 2/2] Allow the SVM CPUID bit in a VM Alexander Graf
2008-09-01 14:00 ` Avi Kivity [this message]
2008-09-02 17:42 ` Alexander Graf
2008-09-02 17:53 ` Alexander Graf
2008-09-02 19:36 ` Itamar Heim
2008-09-03 7:55 ` Gerd Hoffmann
2008-09-03 8:04 ` Alexander Graf
2008-09-03 9:19 ` Avi Kivity
2008-09-03 9:13 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BBF570.9070301@qumranet.com \
--to=avi@qumranet.com \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.