Re: [Qemu-devel] [5120] SH4: Convert remaining non-fp ops to TCG

[Aurelien Jarno <aurelien@aurel32.net>]

Blue Swirl a écrit :
> On 9/1/08, Aurelien Jarno <aurelien@aurel32.net> wrote:
>>  -void OPPROTO op_cmp_str_T0_T1(void)
>>  -{
>>  -    cond_t((T0 & 0x000000ff) == (T1 & 0x000000ff) ||
>>  -          (T0 & 0x0000ff00) == (T1 & 0x0000ff00) ||
>>  -          (T0 & 0x00ff0000) == (T1 & 0x00ff0000) ||
>>  -          (T0 & 0xff000000) == (T1 & 0xff000000));
>>  -    RETURN();
>>  -}
> 
> The above version uses both T0 and T1, but the version below only cpu_T[0].

Yes, I have found my mistake when doing the cpu_T[] removal pass (r5122)
and noted that I have to fix that in this patch, but then I forget and
committed the patch as is.

Anyway the implementation in r5122 is correct.

>>  +           int label1 = gen_new_label();
>>  +           int label2 = gen_new_label();
>>  +           tcg_gen_xor_i32(cpu_T[0], cpu_gregs[REG(B7_4)], cpu_gregs[REG(B11_8)]);
>>  +           tcg_gen_andi_i32(cpu_T[0], cpu_T[0], 0xff000000);
>>  +           tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_T[0], 0, label1);
>>  +           tcg_gen_andi_i32(cpu_T[0], cpu_T[0], 0x00ff0000);
>>  +           tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_T[0], 0, label1);
>>  +           tcg_gen_andi_i32(cpu_T[0], cpu_T[0], 0x0000ff00);
>>  +           tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_T[0], 0, label1);
>>  +           tcg_gen_andi_i32(cpu_T[0], cpu_T[0], 0x000000ff);
>>  +           tcg_gen_brcondi_i32(TCG_COND_EQ, cpu_T[0], 0, label1);
>>  +           tcg_gen_andi_i32(cpu_sr, cpu_sr, ~SR_T);
>>  +           tcg_gen_br(label2);
>>  +           gen_set_label(label1);
>>  +           tcg_gen_ori_i32(cpu_sr, cpu_sr, SR_T);
>>  +           gen_set_label(label2);
> 

-- 
  .''`.  Aurelien Jarno	            | GPG: 1024D/F1BCDB73
 : :' :  Debian developer           | Electrical Engineer
 `. `'   aurel32@debian.org         | aurelien@aurel32.net
   `-    people.debian.org/~aurel32 | www.aurel32.net